netdev - Re: [PATCH 4/5] VSOCK: add sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171003.214652.1920235341803755309.davem@davemloft.net>
Date:   Tue, 03 Oct 2017 21:46:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     stefanha@...hat.com
Cc:     netdev@...r.kernel.org, jhansen@...are.com, decui@...rosoft.com
Subject: Re: [PATCH 4/5] VSOCK: add sock_diag interface

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Tue,  3 Oct 2017 11:39:42 -0400

> +static int sk_diag_fill(struct sock *sk, struct sk_buff *skb,
> +			u32 portid, u32 seq, u32 flags)
> +{
> +	struct nlmsghdr *nlh;
> +	struct vsock_diag_msg *rep;
> +	struct vsock_sock *vsk = vsock_sk(sk);

Please order local variables from longest to shortest line.

> +static int vsock_diag_dump(struct sk_buff *skb, struct netlink_callback *cb)
> +{
> +	struct vsock_diag_req *req;
> +	unsigned int table;
> +	unsigned int bucket;
> +	unsigned int last_i;
> +	unsigned int i;
> +	struct vsock_sock *vsk;
> +	struct net *net;

Likewise.