netdev - Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUhLiTbt-+SWJ2Yq6WxYR+x=hLM_ONyqt+kCDBWbKCTU+w@mail.gmail.com>
Date:   Tue, 3 Oct 2017 21:47:19 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port
 flag to suppress arp and nd flood

On Tue, Oct 3, 2017 at 11:29 AM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Tue,  3 Oct 2017 11:21:14 -0700
> Roopa Prabhu <roopa@...ulusnetworks.com> wrote:
>
>> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
>> index 48fb174..7a50dc5 100644
>> --- a/net/bridge/br_forward.c
>> +++ b/net/bridge/br_forward.c
>> @@ -204,7 +204,8 @@ void br_flood(struct net_bridge *br, struct sk_buff *skb,
>>               /* Do not flood to ports that enable proxy ARP */
>>               if (p->flags & BR_PROXYARP)
>>                       continue;
>> -             if ((p->flags & BR_PROXYARP_WIFI) &&
>> +             if ((p->flags & BR_PROXYARP_WIFI ||
>> +                  p->flags & BR_NEIGH_SUPPRESS) &&
>>                   BR_INPUT_SKB_CB(skb)->proxyarp_replied)
>>                       continue;
>
> Don;t you need additional paren here to avoid warnings.
> Or do one mask:
>                 if ((p->flags & (BR_PROXYARP_WIFI | BR_NEIGH_SUPPRESS)) &&
>                     BR_INPUT_SKB_CB(skb)->proxyarp_replied)
>                         continue;

Missed seeing this, i just posted v3. I did not get a warning. I can
certainly simplify the mask and post.