netdev - Re: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 06 Oct 2017 23:22:29 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     u9012063@...il.com
Cc:     David.Laight@...lab.com, netdev@...r.kernel.org,
        lucien.xin@...il.com
Subject: Re: [PATCH net-next] ip_gre: check packet length and mtu correctly
 in erspan_fb_xmit

From: William Tu <u9012063@...il.com>
Date: Fri, 6 Oct 2017 15:09:29 -0700

> Yes, adding another field in the struct net_device can avoid the
> arithmetic operation. I'm not sure it's a good idea to add new field
> since there are already a lot in net_device.  Let's wait to see how
> others think.

Why would you add it to net_device when you can add it to ip_tunnel?