netdev - Re: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALDO+SZCXUq_CSq_GRRQyBeVFWh1F-jBZDMyPsvcB-ghHbZSpQ@mail.gmail.com>
Date:   Fri, 6 Oct 2017 15:51:05 -0700
From:   William Tu <u9012063@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     David Laight <David.Laight@...lab.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Xin Long <lucien.xin@...il.com>
Subject: Re: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb_xmit

On Fri, Oct 6, 2017 at 3:22 PM, David Miller <davem@...emloft.net> wrote:
> From: William Tu <u9012063@...il.com>
> Date: Fri, 6 Oct 2017 15:09:29 -0700
>
>> Yes, adding another field in the struct net_device can avoid the
>> arithmetic operation. I'm not sure it's a good idea to add new field
>> since there are already a lot in net_device.  Let's wait to see how
>> others think.
>
> Why would you add it to net_device when you can add it to ip_tunnel?
>
I see. I will add it to ip_tunnel and resubmit the patch. Thanks!