netdev - Re: [net-next 01/18] tipc: add ability to order and receive topology events in driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171012.115439.600933914570246341.davem@davemloft.net>
Date:   Thu, 12 Oct 2017 11:54:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, parthasarathy.bhuvaragan@...csson.com,
        ying.xue@...driver.com, tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 01/18] tipc: add ability to order and receive
 topology events in driver

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 12 Oct 2017 16:02:22 +0200

> @@ -288,6 +289,7 @@ static int tipc_receive_from_sock(struct tipc_conn *con)
>  }
>  
>  static int tipc_accept_from_sock(struct tipc_conn *con)
> +
>  {

This whitespace change seems unintentional.

> +bool tipc_topsrv_kern_subscr(struct net *net, u32 port, u32 type,
> +			     u32 lower, u32 upper, int *conid)
> +{
> +	struct tipc_server *s;
> +	struct tipc_conn *con;
> +	struct tipc_subscriber *scbr;
> +	struct tipc_subscr sub;

Please order local variables from longest to shortest line.

>  static void tipc_send_to_sock(struct tipc_conn *con)
>  {
>  	int count = 0;
>  	struct tipc_server *s = con->server;
> +	struct tipc_event *evt;
>  	struct outqueue_entry *e;
>  	struct msghdr msg;
>  	int ret;

Likewise.