netdev - Re: [net-next 04/18] tipc: refactor function filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171012.115613.907390207015671199.davem@davemloft.net>
Date:   Thu, 12 Oct 2017 11:56:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, parthasarathy.bhuvaragan@...csson.com,
        ying.xue@...driver.com, tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 04/18] tipc: refactor function filter_rcv()

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 12 Oct 2017 16:02:25 +0200

> +static void tipc_sk_proto_rcv(struct sock *sk,
> +			      struct sk_buff_head *inputq,
> +			      struct sk_buff_head *xmitq)
> +{
> +	struct tipc_sock *tsk = tipc_sk(sk);
> +	struct sk_buff *skb = __skb_dequeue(inputq);
> +	struct tipc_msg *hdr = buf_msg(skb);

Please order local variables from longest to shortest line.