netdev - Re: [net-next 06/18] tipc: improve destination linked list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171012.115744.1462642148056780607.davem@davemloft.net>
Date:   Thu, 12 Oct 2017 11:57:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, parthasarathy.bhuvaragan@...csson.com,
        ying.xue@...driver.com, tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 06/18] tipc: improve destination linked list

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 12 Oct 2017 16:02:27 +0200

> @@ -259,19 +259,19 @@ static int tipc_rcast_xmit(struct net *net, struct sk_buff_head *pkts,
>  			   struct tipc_nlist *dests, u16 *cong_link_cnt)
>  {
>  	struct sk_buff_head _pkts;
> -	struct u32_item *n, *tmp;
> -	u32 dst, selector;
> +	struct tipc_dest *dst, *tmp;
> +	u32 dnode, selector;

Order local variables from longest to shortest line please.

> -bool u32_find(struct list_head *l, u32 value)
> +struct tipc_dest *tipc_dest_find(struct list_head *l, u32 node, u32 port)
>  {
> -	struct u32_item *item;
> +	struct tipc_dest *dst;
> +	u64 value = (u64)node << 32 | port;

Likewise.

> -bool u32_push(struct list_head *l, u32 value)
> +bool tipc_dest_push(struct list_head *l, u32 node, u32 port)
>  {
> -	struct u32_item *item;
> +	struct tipc_dest *dst;
> +	u64 value = (u64)node << 32 | port;

Likewise.

You're probably tired of hearing me say this, so I'll just ask that you
audit the rest of your patch series for this problem as well.

Thank you :-)