netdev - Re: [PATCH net-next] ipv6: only update __use and lastusetime once per jiffy at most

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171016.210902.1215255184435565936.davem@davemloft.net>
Date:   Mon, 16 Oct 2017 21:09:02 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, kafai@...com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next] ipv6: only update __use and lastusetime once
 per jiffy at most

From: Wei Wang <weiwan@...gle.com>
Date: Fri, 13 Oct 2017 15:08:07 -0700

> From: Wei Wang <weiwan@...gle.com>
> 
> In order to not dirty the cacheline too often, we try to only update
> dst->__use and dst->lastusetime at most once per jiffy.
> As dst->lastusetime is only used by ipv6 garbage collector, it should
> be good enough time resolution.
> And __use is only used in ipv6_route_seq_show() to show how many times a
> dst has been used. And as __use is not atomic_t right now, it does not
> show the precise number of usage times anyway. So we think it should be
> OK to only update it at most once per jiffy.
> 
> According to my latest syn flood test on a machine with intel Xeon 6th
> gen processor and 2 10G mlx nics bonded together, each with 8 rx queues
> on 2 NUMA nodes:
> With this patch, the packet process rate increases from ~3.49Mpps to
> ~3.75Mpps with a 7% increase rate.
> 
> Note: dst_use() is being renamed to dst_hold_and_use() to better specify
> the purpose of the function.
> 
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gl.com>

Also applied, thank you.