netdev - Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171016.212032.2049244038001342016.davem@davemloft.net>
Date:   Mon, 16 Oct 2017 21:20:32 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     ogerlitz@...lanox.com
Cc:     jiri@...lanox.com, netdev@...r.kernel.org, mlxsw@...lanox.com,
        roid@...lanox.com
Subject: Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when
 calling into the HW driver

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Mon, 16 Oct 2017 12:19:48 +0300

> Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress
> Hardware device') made sure (when fl_hw_replace_filter is called) to put
> the egress_dev mark on persisent structure instance. Hence, following calls
> into the HW driver for stats and deletion will note it and act accordingly.
> 
> With commit de4784ca030f this property is lost and hence when called,
> the HW driver failes to operate (stats, delete) on the offloaded flow.
> 
> Fix it by setting the egress_dev flag whenever the ingress device is
> different from the hw device since this is exactly the condition under
> which we're calling into the HW driver through the egress port net-device.
> 
> Fixes: de4784ca030f ('net: sched: get rid of struct tc_to_netdev')
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> Signed-off-by: Roi Dayan <roid@...lanox.com>
> ---
> 
> Hi Dave, the bug was introduced in 4.14-rc1 but later the related
> code was changed in net-next, hence the fix must not go to net-next, Or.

Ok, applied to 'net' and I'll watch out for this next time I merge into
net-next.

Thanks.