netdev - Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a523077-3c05-ba97-8a65-1967765b8d5a@cogentembedded.com>
Date:   Tue, 17 Oct 2017 14:29:13 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Or Gerlitz <ogerlitz@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
        mlxsw@...lanox.com, Roi Dayan <roid@...lanox.com>
Subject: Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when
 calling into the HW driver

Hello!

On 10/16/2017 12:19 PM, Or Gerlitz wrote:

> Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress

    At least 12 digits are needed.

> Hardware device') made sure (when fl_hw_replace_filter is called) to put
> the egress_dev mark on persisent structure instance. Hence, following calls

    Persistent.

> into the HW driver for stats and deletion will note it and act accordingly.
> 
> With commit de4784ca030f this property is lost and hence when called,
> the HW driver failes to operate (stats, delete) on the offloaded flow.

    Fails.

> Fix it by setting the egress_dev flag whenever the ingress device is
> different from the hw device since this is exactly the condition under
> which we're calling into the HW driver through the egress port net-device.
> 
> Fixes: de4784ca030f ('net: sched: get rid of struct tc_to_netdev')
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> Signed-off-by: Roi Dayan <roid@...lanox.com>
[...]

MBR, Sergei