netdev - Re: [PATCH net-next v2 2/2] net: add skb_memcpy_to[from]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Oct 2017 12:18:34 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     cugyly@....com
Cc:     netdev@...r.kernel.org, Linyu.Yuan@...atel-sbell.com.cn
Subject: Re: [PATCH net-next v2 2/2] net: add skb_memcpy_to[from]_msg() to
 optimize skb code

From: yuan linyu <cugyly@....com>
Date: Mon, 16 Oct 2017 20:11:13 +0800

> From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> 
> add these two wrappers in skbuff.h which is better named
> than previous and only used for skb.
> 
> Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>

Doing the skb_put() inside of the helper function makes code less
intuitive.

If someone is auditing code it's easier to see the skb_put() and
understand what is happening when it's at the call site rather than
buried in some helper.

Sorry, I don't see these changes as an improvement and will not apply
them.

Thank you.