netdev - Re: [PATCH net] geneve: Fix function matching VNI and tunnel ID on big-endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 14:08:21 +0200
From:   Jakub Sitnicki <jkbs@...hat.com>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        pravin shelar <pshelar@....org>,
        Girish Moodalbail <girish.moodalbail@...cle.com>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH net] geneve: Fix function matching VNI and tunnel ID on
 big-endian

On Thu, 19 Oct 2017 13:31:28 +0200
Stefano Brivio <sbrivio@...hat.com> wrote:

> On big-endian machines, functions converting between tunnel ID
> and VNI use the three LSBs of tunnel ID storage to map VNI.
> 
> The comparison function eq_tun_id_and_vni(), on the other hand,
> attempted to map the VNI from the three MSBs. Fix it by using
> the same check implemented on LE, which maps VNI from the three
> LSBs of tunnel ID.
> 
> Fixes: 2e0b26e10352 ("geneve: Optimize geneve device lookup.")
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>

Thanks, Stefano.

Reviewed-by: Jakub Sitnicki <jkbs@...hat.com>