netdev - Re: [PATCH net] geneve: Fix function matching VNI and tunnel ID on big-endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171021.025121.1181909163959289258.davem@davemloft.net>
Date:   Sat, 21 Oct 2017 02:51:21 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     sbrivio@...hat.com
Cc:     netdev@...r.kernel.org, pshelar@....org,
        girish.moodalbail@...cle.com, sd@...asysnail.net
Subject: Re: [PATCH net] geneve: Fix function matching VNI and tunnel ID on
 big-endian

From: Stefano Brivio <sbrivio@...hat.com>
Date: Thu, 19 Oct 2017 13:31:28 +0200

> On big-endian machines, functions converting between tunnel ID
> and VNI use the three LSBs of tunnel ID storage to map VNI.
> 
> The comparison function eq_tun_id_and_vni(), on the other hand,
> attempted to map the VNI from the three MSBs. Fix it by using
> the same check implemented on LE, which maps VNI from the three
> LSBs of tunnel ID.
> 
> Fixes: 2e0b26e10352 ("geneve: Optimize geneve device lookup.")
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>
> ---
> I guess this should be queued up for -stable, back to 4.10

Applied and queued up for -stable, thanks.