netdev - Re: [PATCH] net/unix: don't show information about sockets from other namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171025190051.GA10391@outlook.office365.com>
Date:   Wed, 25 Oct 2017 12:00:52 -0700
From:   Andrei Vagin <avagin@...tuozzo.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Andrei Vagin <avagin@...nvz.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/unix: don't show information about sockets from
 other namespaces

On Wed, Oct 25, 2017 at 06:37:16AM -0700, Eric Dumazet wrote:
> On Wed, 2017-10-25 at 00:17 -0700, Andrei Vagin wrote:
> > socket_diag shows information only about sockets from a namespace where
> > a diag socket lives.
> > 
> > But if we request information about one unix socket, the kernel don't
> > check that its netns is matched with a diag socket namespace, so any
> > user can get information about any unix socket in a system. This looks
> > like a bug.
> 
> Then if this a bug please provide a Fixes: tag
> 
> This way, we can know exact cutoff for backports.
> 
> I suspect that would be 
> 
> Fixes: 51d7cccf0723 ("net: make sock diag per-namespace")

Thank you, Eric. It's my fault, I forgot to add it.

> 
> Thanks.
> 
>