netdev - Re: [PATCH net] nfp: refuse offloading filters that redirects to upper devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171026.100906.356711178165834262.davem@davemloft.net>
Date:   Thu, 26 Oct 2017 10:09:06 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        pieter.jansenvanvuuren@...ronome.com
Subject: Re: [PATCH net] nfp: refuse offloading filters that redirects to
 upper devices

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 25 Oct 2017 11:47:05 -0700

> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> 
> Previously we did not ensure that a netdev is a representative netdev
> before dereferencing its private data. This can occur when an upper netdev
> is created on a representative netdev. This patch corrects this by first
> ensuring that the netdev is a representative netdev before using it.
> Checking only switchdev_port_same_parent_id is not sufficient to ensure
> that we can safely use the netdev. Failing to check that the netdev is also
> a representative netdev would result in incorrect dereferencing.
> 
> Fixes: 1a1e586f54bf ("nfp: add basic action capabilities to flower offloads")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>

Applied and queued up for -stable.