netdev - Re: [PATCH net] tun: allow positive return values on dev_get_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171026.101036.1867665865960470441.davem@davemloft.net>
Date:   Thu, 26 Oct 2017 10:10:36 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     julien@...sta.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com
Subject: Re: [PATCH net] tun: allow positive return values on
 dev_get_valid_name() call

From: Julien Gomes <julien@...sta.com>
Date: Wed, 25 Oct 2017 11:50:50 -0700

> If the name argument of dev_get_valid_name() contains "%d", it will try
> to assign it a unit number in __dev__alloc_name() and return either the
> unit number (>= 0) or an error code (< 0).
> Considering positive values as error values prevent tun device creations
> relying this mechanism, therefor we should only consider negative values
> as errors here.
> 
> Signed-off-by: Julien Gomes <julien@...sta.com>

Applied, thanks.