netdev - Re: [PATCH net] tun: allow positive return values on dev_get_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXP1zKL=WjBtCxEXmy1k4+QX8AD-QibkEmsSp0xRixBjw@mail.gmail.com>
Date:   Wed, 25 Oct 2017 13:40:59 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Julien Gomes <julien@...sta.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] tun: allow positive return values on
 dev_get_valid_name() call

On Wed, Oct 25, 2017 at 11:50 AM, Julien Gomes <julien@...sta.com> wrote:
> If the name argument of dev_get_valid_name() contains "%d", it will try
> to assign it a unit number in __dev__alloc_name() and return either the
> unit number (>= 0) or an error code (< 0).
> Considering positive values as error values prevent tun device creations
> relying this mechanism, therefor we should only consider negative values
> as errors here.
>
> Signed-off-by: Julien Gomes <julien@...sta.com>

Good catch! I missed this case indeed. We'd better document it
in the future.

Acked-by: Cong Wang <xiyou.wangcong@...il.com>