netdev - [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1509008225-19614-1-git-send-email-hustcat@gmail.com>
Date:   Thu, 26 Oct 2017 16:57:05 +0800
From:   Ye Yin <hustcat@...il.com>
To:     davem@...emloft.net
Cc:     willemb@...gle.com, edumazet@...gle.com, johannes.berg@...el.com,
        dcaratti@...hat.com, pabeni@...hat.com, f.fainelli@...il.com,
        fw@...len.de, soheil@...gle.com, dwindsor@...il.com,
        elena.reshetova@...el.com, tom@...ntonium.net, Jason@...c4.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Ye Yin <hustcat@...il.com>, Wei Zhou <chouryzhou@...il.com>
Subject: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed

When run ipvs in two different network namespace at the same host, and one
ipvs transport network traffic to the other network namespace ipvs.
'ipvs_property' flag will make the second ipvs take no effect. So we should
clear 'ipvs_property' when SKB network namespace changed.

Signed-off-by: Ye Yin <hustcat@...il.com>
Signed-off-by: Wei Zhou <chouryzhou@...il.com>
---
 include/linux/skbuff.h | 7 +++++++
 net/core/skbuff.c      | 1 +
 2 files changed, 8 insertions(+)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 72299ef..d448a48 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -3770,6 +3770,13 @@ static inline void nf_reset_trace(struct sk_buff *skb)
 #endif
 }
 
+static inline void ipvs_reset(struct sk_buff *skb)
+{
+#if IS_ENABLED(CONFIG_IP_VS)
+	skb->ipvs_property = 0;
+#endif
+}
+
 /* Note: This doesn't put any conntrack and bridge info in dst. */
 static inline void __nf_copy(struct sk_buff *dst, const struct sk_buff *src,
 			     bool copy)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 2465607..e140ba4 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4864,6 +4864,7 @@ void skb_scrub_packet(struct sk_buff *skb, bool xnet)
 	if (!xnet)
 		return;
 
+	ipvs_reset(skb);
 	skb_orphan(skb);
 	skb->mark = 0;
 }
-- 
1.7.12.4