netdev - Re: [PATCH v2] tap: double-free in error path in tap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171026.175812.1985944633273201892.davem@davemloft.net>
Date:   Thu, 26 Oct 2017 17:58:12 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     girish.moodalbail@...cle.com
Cc:     netdev@...r.kernel.org, jasowang@...hat.com
Subject: Re: [PATCH v2] tap: double-free in error path in tap_open()

From: Girish Moodalbail <girish.moodalbail@...cle.com>
Date: Wed, 25 Oct 2017 00:23:04 -0700

> Double free of skb_array in tap module is causing kernel panic. When
> tap_set_queue() fails we free skb_array right away by calling
> skb_array_cleanup(). However, later on skb_array_cleanup() is called
> again by tap_sock_destruct through sock_put(). This patch fixes that
> issue.
> 
> Fixes: 362899b8725b35e3 (macvtap: switch to use skb array)
> Signed-off-by: Girish Moodalbail <girish.moodalbail@...cle.com>
> ---
> v1 -> v2:
>   - took care of an another issue in failure path of skb_array_init

Applied and queued up for -stable, thanks.