netdev - Re: [PATCH] r8169: Add support for interrupt coalesce tuning (ethtool -C)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17a1d528-5127-e01d-d982-87be3b09cba5@applied-asynchrony.com>
Date:   Fri, 27 Oct 2017 14:43:02 +0200
From:   Holger Hoffstätte <holger@...lied-asynchrony.com>
To:     Kirill Smelkov <kirr@...edi.com>,
        David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Francois Romieu <romieu@...zoreil.com>,
        Hayes Wang <hayeswang@...ltek.com>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        David Laight <David.Laight@...LAB.COM>,
        Stéphane ANCELOT <sancelot@...e.fr>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] r8169: Add support for interrupt coalesce tuning (ethtool
 -C)

On 10/27/17 12:24, Kirill Smelkov wrote:
> 
> Kirr: In particular with
> 
> 	ethtool -C <ifname> rx-usecs 0 rx-frames 0
> 
> now it is possible to disable RX delays when NIC usage requires low-latency.
> 
> See this thread for context:
> 
> 	https://www.spinics.net/lists/netdev/msg217665.html

(snip)

> We have this patch running in our testing setup for 1 months already
> without any issues observed.

Same here, running on NFS/mail/web server & development workstation without
issues. I was really dismayed to see the IMHO unreasonably high coalescing
defaults.

> I've got no feedback at all to my original posting of this patch and questions
> 
> 	https://www.spinics.net/lists/netdev/msg457173.html
> 
> neither from Francois, nor from any people from Realtek during one month.

I thought I had already replied to your previous mail, but apparently had
not..sorry. :/

Tested-by: Holger Hoffstätte <holger@...lied-asynchrony.com>

> So I suggest we simply apply it to net-next.git now.

cheers!

Holger