netdev - Re: [PATCH] r8169: Add support for interrupt coalesce tuning (ethtool -C)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171027125414.fs27hokqmlnrsse7@deco.navytux.spb.ru>
Date:   Fri, 27 Oct 2017 15:54:14 +0300
From:   Kirill Smelkov <kirr@...edi.com>
To:     Holger Hoffstätte 
        <holger@...lied-asynchrony.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Francois Romieu <romieu@...zoreil.com>,
        Hayes Wang <hayeswang@...ltek.com>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        David Laight <David.Laight@...LAB.COM>,
        Stéphane ANCELOT <sancelot@...e.fr>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] r8169: Add support for interrupt coalesce tuning
 (ethtool -C)

On Fri, Oct 27, 2017 at 02:43:02PM +0200, Holger Hoffstätte wrote:
> On 10/27/17 12:24, Kirill Smelkov wrote:
> > 
> > Kirr: In particular with
> > 
> > 	ethtool -C <ifname> rx-usecs 0 rx-frames 0
> > 
> > now it is possible to disable RX delays when NIC usage requires low-latency.
> > 
> > See this thread for context:
> > 
> > 	https://www.spinics.net/lists/netdev/msg217665.html
> 
> (snip)
> 
> > We have this patch running in our testing setup for 1 months already
> > without any issues observed.
> 
> Same here, running on NFS/mail/web server & development workstation without
> issues. I was really dismayed to see the IMHO unreasonably high coalescing
> defaults.
> 
> > I've got no feedback at all to my original posting of this patch and questions
> > 
> > 	https://www.spinics.net/lists/netdev/msg457173.html
> > 
> > neither from Francois, nor from any people from Realtek during one month.
> 
> I thought I had already replied to your previous mail, but apparently had
> not..sorry. :/
> 
> Tested-by: Holger Hoffstätte <holger@...lied-asynchrony.com>

Holger, thanks for feedback.

Kirill


> > So I suggest we simply apply it to net-next.git now.
> 
> cheers!
> 
> Holger