netdev - Re: [RFC v2 PATCH 09/11] net: Rearrange dst_entry layout to avoid useless padding.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509475794.3828.36.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 31 Oct 2017 11:49:54 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC v2 PATCH 09/11] net: Rearrange dst_entry layout to avoid
 useless padding.

On Tue, 2017-10-31 at 23:10 +0900, David S. Miller wrote:
> We have padding to try and align the refcount on a separate cache
> line.  But after several simplifications the padding has increased
> substantially.
> 
> So now it's easy to change the layout to get rid of the padding
> entirely.
> 
> We group the write-heavy __refcnt and __use with less often used
> items such as the rcu_head and the error code.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>