netdev - Re: [RFC v2 PATCH 10/11] xfrm: Stop using dst->next in bundle construction.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509475946.3828.37.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 31 Oct 2017 11:52:26 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC v2 PATCH 10/11] xfrm: Stop using dst->next in bundle
 construction.

On Tue, 2017-10-31 at 23:10 +0900, David S. Miller wrote:
> While building ipsec bundles, blocks of xfrm dsts are linked together
> using dst->next from bottom to the top.
> 
> The only thing this is used for is initializing the pmtu values of the
> xfrm stack, and for updating the mtu values at xfrm_bundle_ok() time.
> 
> The bundle pmtu entries must be processed in this order so that pmtu
> values lower in the stack of routes can propagate up to the higher
> ones.
> 
> Avoid using dst->next by simply maintaining an array of dst pointers
> as we already do for the xfrm_state objects when building the bundle.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>