netdev - Re: [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66baa4b6-7588-501e-4ad7-e0617329ac4e@gmx.de>
Date:   Tue, 31 Oct 2017 12:37:52 +0100
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Colin King <colin.king@...onical.com>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] net: ethernet: slicoss: remove redundant
 initialization of idx

On 31.10.2017 11:08, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable idx is being initialized and later on over-written by
> a new value in a do-loop without the initial value ever being
> read. Hence the initializion is redundant and can be removed.
> Cleans up clang warning:
> 
> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
> stored to 'idx' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index 15a8096c60df..0b60921c392f 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -355,10 +355,10 @@ static void slic_xmit_complete(struct slic_device *sdev)
>  {
>  	struct slic_tx_queue *txq = &sdev->txq;
>  	struct net_device *dev = sdev->netdev;
> -	unsigned int idx = txq->done_idx;
>  	struct slic_tx_buffer *buff;
>  	unsigned int frames = 0;
>  	unsigned int bytes = 0;
> +	unsigned int idx;
>  
>  	/* Limit processing to SLIC_MAX_TX_COMPLETIONS frames to avoid that new
>  	 * completions during processing keeps the loop running endlessly.
> 

Acked-by: Lino Sanfilippo <LinoSanfilippo@....de>

Regards,
Lino