netdev - Re: [PATCH net-next] tcp: fix a lockdep issue in tcp_fastopen_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20171102195506.GY44287@da0602a-dhcp105.apple.com>
Date:   Thu, 02 Nov 2017 12:55:06 -0700
From:   Christoph Paasch <cpaasch@...le.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net-next] tcp: fix a lockdep issue in
 tcp_fastopen_reset_cipher()

On 02/11/17 - 11:53:04, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> icsk_accept_queue.fastopenq.lock is only fully initialized at listen()
> time.
> 
> LOCKDEP is not happy if we attempt a spin_lock_bh() on it, because
> of missing annotation. (Although kernel runs just fine)
> 
> Lets use net->ipv4.tcp_fastopen_ctx_lock to protect ctx access.
> 
> Fixes: 1fba70e5b6be ("tcp: socket option to set TCP fast open key")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Yuchung Cheng <ycheng@...gle.com>
> Cc: Christoph Paasch <cpaasch@...le.com>
> ---
>  net/ipv4/tcp_fastopen.c |    8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Christoph Paasch <cpaasch@...le.com>