netdev - Re: [PATCH net-next] tcp: fix a lockdep issue in tcp_fastopen_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171103.155444.2169913803825248503.davem@davemloft.net>
Date:   Fri, 03 Nov 2017 15:54:44 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, ycheng@...gle.com, cpaasch@...le.com
Subject: Re: [PATCH net-next] tcp: fix a lockdep issue in
 tcp_fastopen_reset_cipher()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 02 Nov 2017 11:53:04 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> icsk_accept_queue.fastopenq.lock is only fully initialized at listen()
> time.
> 
> LOCKDEP is not happy if we attempt a spin_lock_bh() on it, because
> of missing annotation. (Although kernel runs just fine)
> 
> Lets use net->ipv4.tcp_fastopen_ctx_lock to protect ctx access.
> 
> Fixes: 1fba70e5b6be ("tcp: socket option to set TCP fast open key")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.