netdev - Re: [PATCH net-next] liquidio: Fix an issue with multiple switchdev enable disables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171104.091831.822922406654465563.davem@davemloft.net>
Date:   Sat, 04 Nov 2017 09:18:31 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        vijaya.guvva@...ium.com
Subject: Re: [PATCH net-next] liquidio: Fix an issue with multiple
 switchdev enable disables

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Fri, 3 Nov 2017 12:17:44 -0700

> From: Vijaya Mohan Guvva <vijaya.guvva@...ium.com>
> 
> Return success if the same dispatch function is being registered for
> a given opcode and subcode, there by allow multiple switchdev enable
> and disables.
> 
> Signed-off-by: Vijaya Mohan Guvva <vijaya.guvva@...ium.com>
> Signed-off-by: Satanand Burla <satananda.burla@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>

Applied, thanks.

But I do have a question, are you properly reference counting these
dispatch function objects?  I can't see how you can properly handle
multiple enable/disable otherwise.

Thank you.