netdev - RE: [PATCH net-next] liquidio: Fix an issue with multiple switchdev enable disables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM3PR07MB21546D9EF687EDAFE2D78E48E1500@DM3PR07MB2154.namprd07.prod.outlook.com>
Date:   Mon, 6 Nov 2017 23:36:35 +0000
From:   "Guvva, Vijaya" <Vijaya.Guvva@...ium.com>
To:     David Miller <davem@...emloft.net>,
        "Manlunas, Felix" <Felix.Manlunas@...ium.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Vatsavayi, Raghu" <Raghu.Vatsavayi@...ium.com>,
        "Chickles, Derek" <Derek.Chickles@...ium.com>,
        "Burla, Satananda" <Satananda.Burla@...ium.com>
Subject: RE: [PATCH net-next] liquidio: Fix an issue with multiple switchdev
 enable disables

>Applied, thanks.
>
>But I do have a question, are you properly reference counting these dispatch
>function objects?  I can't see how you can properly handle multiple
>enable/disable otherwise.
>
LiquidIO doesn't reference count dispatch function as no two LiquidIO components
registers for the same opcode/subcode combination and every physical function
will have its own dispatch functions list.
Right now, we don't have an implementation to unregister dispatch functions selectively,
which we supposed to do for switchdev disable. So, we allow multiple switchdev
enable/disables (in a sequence) by not failing the registration for opcode/subcode if the
new dispatch functions matches with the old one.

We will submit implementation for unregistering dispatch function in future patch.