netdev - Re: [PATCH net-next] tools: bpftool: move p_err() and p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171104094607.q6jigobmd4msm52g@ast-mbp>
Date:   Sat, 4 Nov 2017 18:46:10 +0900
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [PATCH net-next] tools: bpftool: move p_err() and p_info() from
 main.h to common.c

On Fri, Nov 03, 2017 at 01:59:07PM -0700, Jakub Kicinski wrote:
> From: Quentin Monnet <quentin.monnet@...ronome.com>
> 
> The two functions were declared as static inline in a header file. There
> is no particular reason why they should be inlined, they just happened to
> remain in the same header file when they were turned from macros to
> functions in a precious commit.
> 
> Make them non-inlined functions and move them to common.c file instead.
> 
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Quentin Monnet <quentin.monnet@...ronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Alexei Starovoitov <ast@...nel.org>