netdev - Re: [PATCH net-next] tools: bpftool: move p_err() and p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171105.222905.2113705675362671569.davem@davemloft.net>
Date:   Sun, 05 Nov 2017 22:29:05 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        quentin.monnet@...ronome.com
Subject: Re: [PATCH net-next] tools: bpftool: move p_err() and p_info()
 from main.h to common.c

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri,  3 Nov 2017 13:59:07 -0700

> From: Quentin Monnet <quentin.monnet@...ronome.com>
> 
> The two functions were declared as static inline in a header file. There
> is no particular reason why they should be inlined, they just happened to
> remain in the same header file when they were turned from macros to
> functions in a precious commit.
> 
> Make them non-inlined functions and move them to common.c file instead.
> 
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Quentin Monnet <quentin.monnet@...ronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied.