netdev - Re: [PATCH 20/21] phonet: exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7B8FCA41-D41E-47B1-A5D3-37E8A9C55BE3@remlab.net>
Date:   Sun, 05 Nov 2017 12:17:42 +0200
From:   Rémi Denis-Courmont <remi@...lab.net>
To:     Vasily Averin <vvs@...tuozzo.com>, netdev@...r.kernel.org
CC:     Remi Denis-Courmont <courmisch@...il.com>
Subject: Re: [PATCH 20/21] phonet: exit_net cleanup check added

Le 5 novembre 2017 12:02:34 GMT+02:00, Vasily Averin <vvs@...tuozzo.com> a écrit :
>Be sure that pndevs.list initialized in net_init hook was return
>to initial state.
>
>Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
>---
> net/phonet/pn_dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
>index 2cb4c5d..1024851 100644
>--- a/net/phonet/pn_dev.c
>+++ b/net/phonet/pn_dev.c
>@@ -332,6 +332,8 @@ static int __net_init phonet_init_net(struct net
>*net)
> static void __net_exit phonet_exit_net(struct net *net)
> {
> 	remove_proc_entry("phonet", net->proc_net);
>+	WARN(!list_empty(&pnn->pndevs.list),
>+	     "net %p exit: phonet pndevs.list is not empty\n", net);
> }
> 
> static struct pernet_operations phonet_net_ops = {

Hello,

TBH, I am not clear what the benefit of this is supposed to be... also, does this not leak a pointer to userspace, breaking ASLR?
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.