netdev - Re: [PATCH v2] net: macb: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171108.152914.951411855350219382.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 15:29:14 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     m.grzeschik@...gutronix.de
Cc:     nicolas.ferre@...rochip.com, netdev@...r.kernel.org,
        kernel@...gutronix.de, andrew@...n.ch
Subject: Re: [PATCH v2] net: macb: add of_node_put to error paths

From: Michael Grzeschik <m.grzeschik@...gutronix.de>
Date: Tue,  7 Nov 2017 10:59:49 +0100

> @@ -611,6 +611,7 @@ static int macb_mii_init(struct macb *bp)
>  err_out_unregister_bus:
>  	mdiobus_unregister(bp->mii_bus);
>  err_out_free_mdiobus:
> +	of_node_put(bp->phy_node);
>  	if ((np) && (of_phy_is_fixed_link(np)))
>  		of_phy_deregister_fixed_link(np);
>  	mdiobus_free(bp->mii_bus);

This is relative to another patch which has not been applied.

Please do not do this.