netdev - Re: [PATCH 1/2] net: macb: add of_phy_deregister_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171108.132257.965316421222736859.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 13:22:57 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     m.grzeschik@...gutronix.de
Cc:     nicolas.ferre@...rochip.com, netdev@...r.kernel.org,
        kernel@...gutronix.de, andrew@...n.ch
Subject: Re: [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to
 error paths

From: Michael Grzeschik <m.grzeschik@...gutronix.de>
Date: Mon,  6 Nov 2017 12:10:04 +0100

> We add the call of_phy_deregister_fixed_link to all associated
> error paths for memory clean up.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
> ---
>  drivers/net/ethernet/cadence/macb_main.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 6df2cad61647a..2c2acd011329a 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -611,6 +611,8 @@ static int macb_mii_init(struct macb *bp)
>  err_out_unregister_bus:
>  	mdiobus_unregister(bp->mii_bus);
>  err_out_free_mdiobus:
> +	if ((np) && (of_phy_is_fixed_link(np)))

Please don't use so many parenthesis in your conditionals:

	if (np && of_phy_is_fixed_link(np))

is more than sufficient.

Please fix this in your entire set of patches.

Thank you.