netdev - Re: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMikKDeUDdXPn9gjKB_iL8itSyz_Q5U6Y+UrKZ6E6SCHrw@mail.gmail.com>
Date:   Wed, 8 Nov 2017 23:13:05 +0900
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Yevgeny Kliteynik <kliteyn@...lanox.com>,
        Kamal Heib <kamalh@...lanox.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero

On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed <saeedm@...lanox.com> wrote:
> From: Kamal Heib <kamalh@...lanox.com>
>
> In the current code, if a size of zero is passed to
> mlx5_fpga_mem_{read|write}_i2c() functions the "err"

Don't we need to fix the call site where zero size is provided and not
in called function?

Isn't sending down a zero size a sign for a bug which we are not fixing?

> return value will not initialized.
>
> Fixes: a9956d35d199 ('net/mlx5: FPGA, Add SBU infrastructure')
> Signed-off-by: Kamal Heib <kamalh@...lanox.com>
> Reviewed-by: Yevgeny Kliteynik <kliteyn@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>