netdev - Re: [net 2/6] net/mlx5: Cancel health poll before sending panic teardown command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMiJ+7LjxNY_6idr2OEHVoXmaonPGuKXthoc+EQvgNXQGg@mail.gmail.com>
Date:   Wed, 8 Nov 2017 23:28:18 +0900
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        Majd Dibbiny <majd@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Huy Nguyen <huyn@...lanox.com>
Subject: Re: [net 2/6] net/mlx5: Cancel health poll before sending panic
 teardown command

On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed <saeedm@...lanox.com> wrote:
> From: Huy Nguyen <huyn@...lanox.com>
>
> After the panic teardown firmware command, health_care detects the error
> in PCI bus and calls the mlx5_pci_err_detected. This health_care flow is
> no longer needed because the panic teardown firmware command will bring
> down the PCI bus communication with the HCA.
>
> The solution is to cancel the health care timer and its pending
> workqueue request before sending panic teardown firmware command.
>
> Kernel trace:
> mlx5_core 0033:01:00.0: Shutdown was called
> mlx5_core 0033:01:00.0: health_care:154:(pid 9304): handling bad device here
> mlx5_core 0033:01:00.0: mlx5_handle_bad_state:114:(pid 9304): NIC state 1
> mlx5_core 0033:01:00.0: mlx5_pci_err_detected was called
> mlx5_core 0033:01:00.0: mlx5_enter_error_state:96:(pid 9304): start
> mlx5_3:mlx5_ib_event:3061:(pid 9304): warning: event on port 0
> mlx5_core 0033:01:00.0: mlx5_enter_error_state:104:(pid 9304): end
> Unable to handle kernel paging request for data at address 0x0000003f
> Faulting instruction address: 0xc0080000434b8c80
>
> Fixes: 8812c24d28f4 ('net/mlx5: Add fast unload support in shutdown flow')
> Signed-off-by: Huy Nguyen <huyn@...lanox.com>
> Reviewed-by: Majd Dibbiny <majd@...lanox.com>

something might have went wrong here with the reviewer, we are
checking that internally

> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>