netdev - Re: [PATCH] ipvlan: fix ipv6 outbound device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <17EB61BE5174F5429F67504099B599AFAE75A0@DGGEMM501-MBX.china.huawei.com>
Date:   Fri, 10 Nov 2017 00:56:09 +0000
From:   liuqifa <liuqifa@...wei.com>
To:     Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>
CC:     David Miller <davem@...emloft.net>,
        "fgao@...ai8.com" <fgao@...ai8.com>,
        "sainath.grandhi@...el.com" <sainath.grandhi@...el.com>,
        Eric Dumazet <edumazet@...gle.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipvlan: fix ipv6 outbound device

That's a good question.
Recently, I am researching how to use ipvlan, I found when using L3 mode, the packet from
the ipvlan slave interface can only get out from the phy device which the slave interface attached,
and I found this is assigning the flowi4's output device result, so I tried to don't assign the
output device, I found the packet from the ipvlan slave interface can be forwarded to another
phy device, but it has bringing some other problem.
At the same time, when I read the code, I found the process of ipv6 packet is different, so I think
this is a bug.
I am look forward to listening to your advice!

---------------------------------------------------------------------------------------------------------------------------
On Thu, Nov 9, 2017 at 9:09 PM,  <liuqifa@...wei.com> wrote:
> From: Keefe Liu <liuqifa@...wei.com>
>
> When process the outbound packet of ipv6, we should assign the master 
> device to output device other than input device.
>
curious to know, how you discovered this?

> Signed-off-by: Keefe Liu <liuqifa@...wei.com>
Acked-by: Mahesh Bandewar <maheshb@...gle.com>
> ---
>  drivers/net/ipvlan/ipvlan_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_core.c 
> b/drivers/net/ipvlan/ipvlan_core.c
> index 034ae4c..f2a7e92 100644
> --- a/drivers/net/ipvlan/ipvlan_core.c
> +++ b/drivers/net/ipvlan/ipvlan_core.c
> @@ -409,7 +409,7 @@ static int ipvlan_process_v6_outbound(struct sk_buff *skb)
>         struct dst_entry *dst;
>         int err, ret = NET_XMIT_DROP;
>         struct flowi6 fl6 = {
> -               .flowi6_iif = dev->ifindex,
> +               .flowi6_oif = dev->ifindex,
>                 .daddr = ip6h->daddr,
>                 .saddr = ip6h->saddr,
>                 .flowi6_flags = FLOWI_FLAG_ANYSRC,
> --
> 1.8.3.1
>
>