netdev - Re: [PATCH v2] net: mvneta: fix handling of the Tx descriptor counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171114.215337.2029697539551703912.davem@davemloft.net>
Date:   Tue, 14 Nov 2017 21:53:37 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     simon.guinot@...uanux.org
Cc:     thomas.petazzoni@...e-electrons.com, netdev@...r.kernel.org,
        musv@....de, andreas.tobler@...udguard.ch,
        gregory.clement@...e-electrons.com,
        antoine.tenart@...e-electrons.com, mw@...ihalf.com,
        stable@...r.kernel.org, David.Laight@...LAB.COM
Subject: Re: [PATCH v2] net: mvneta: fix handling of the Tx descriptor
 counter

From: Simon Guinot <simon.guinot@...uanux.org>
Date: Mon, 13 Nov 2017 16:27:02 +0100

> The mvneta controller provides a 8-bit register to update the pending
> Tx descriptor counter. Then, a maximum of 255 Tx descriptors can be
> added at once. In the current code the mvneta_txq_pend_desc_add function
> assumes the caller takes care of this limit. But it is not the case. In
> some situations (xmit_more flag), more than 255 descriptors are added.
> When this happens, the Tx descriptor counter register is updated with a
> wrong value, which breaks the whole Tx queue management.
> 
> This patch fixes the issue by allowing the mvneta_txq_pend_desc_add
> function to process more than 255 Tx descriptors.
> 
> Fixes: 2a90f7e1d5d0 ("net: mvneta: add xmit_more support")
> Cc: stable@...r.kernel.org # 4.11+
> Signed-off-by: Simon Guinot <simon.guinot@...uanux.org>

Applied.