netdev - Re: [PATCH net] route: update fnhe_expires for redirect when the fnhe exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171118.103507.1606377296636037986.davem@davemloft.net>
Date:   Sat, 18 Nov 2017 10:35:07 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, hannes@...essinduktion.org,
        pabeni@...hat.com
Subject: Re: [PATCH net] route: update fnhe_expires for redirect when the
 fnhe exists

From: Xin Long <lucien.xin@...il.com>
Date: Fri, 17 Nov 2017 14:27:06 +0800

> Now when creating fnhe for redirect, it sets fnhe_expires for this
> new route cache. But when updating the exist one, it doesn't do it.
> It will cause this fnhe never to be expired.
> 
> Paolo already noticed it before, in Jianlin's test case, it became
> even worse:
> 
> When ip route flush cache, the old fnhe is not to be removed, but
> only clean it's members. When redirect comes again, this fnhe will
> be found and updated, but never be expired due to fnhe_expires not
> being set.
> 
> So fix it by simply updating fnhe_expires even it's for redirect.
> 
> Fixes: aee06da6726d ("ipv4: use seqlock for nh_exceptions")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied.