netdev - Re: [PATCH net] route: also update fnhe_genid when updating a route cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171118.103514.756262305568015490.davem@davemloft.net>
Date:   Sat, 18 Nov 2017 10:35:14 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, hannes@...essinduktion.org,
        pabeni@...hat.com
Subject: Re: [PATCH net] route: also update fnhe_genid when updating a
 route cache

From: Xin Long <lucien.xin@...il.com>
Date: Fri, 17 Nov 2017 14:27:18 +0800

> Now when ip route flush cache and it turn out all fnhe_genid != genid.
> If a redirect/pmtu icmp packet comes and the old fnhe is found and all
> it's members but fnhe_genid will be updated.
> 
> Then next time when it looks up route and tries to rebind this fnhe to
> the new dst, the fnhe will be flushed due to fnhe_genid != genid. It
> causes this redirect/pmtu icmp packet acutally not to be applied.
> 
> This patch is to also reset fnhe_genid when updating a route cache.
> 
> Fixes: 5aad1de5ea2c ("ipv4: use separate genid for next hop exceptions")
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied.