netdev - Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B761CA08-7DA0-4ABD-AD5F-85DCF32308E3@mork.no>
Date:   Mon, 20 Nov 2017 07:57:12 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     ssjoholm@....com, netdev@...r.kernel.org
CC:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        ssjoholm <ssjoholm@....com>
Subject: Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296



On November 20, 2017 5:19:21 AM GMT+01:00, ssjoholm@....com wrote:
>From: ssjoholm <ssjoholm@....com>
>
>Signed-off-by: ssjoholm <ssjoholm@....com>
>
>Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
>CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel
>development board (EVB).
>The USB id is added to qmi_wwan.c to allow QMI communication with the
>BG96.
>---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>index 720a3a248070..c750cf7c042b 100644
>--- a/drivers/net/usb/qmi_wwan.c
>+++ b/drivers/net/usb/qmi_wwan.c
>@@ -1239,6 +1239,7 @@ static const struct usb_device_id products[] = {
> 	{QMI_FIXED_INTF(0x1e0e, 0x9001, 5)},	/* SIMCom 7230E */
>	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0125, 4)},	/* Quectel EC25, EC20 R2.0 
>Mini PCIe */
> 	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
>+	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> 
> 	/* 4. Gobi 1000 devices */
> 	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

Patch looks fine. But you need to use your full name in the tags. 
See the part about identity;
https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup

And the SOB and other tags go after the rest of the commit message. Your SOB should always be the last line. 



Bjørn