netdev - Re: [PATCH net 04/10] bpf: offload: move offload device validation out to the drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171120071104.GB2093@nanopsycho>
Date:   Mon, 20 Nov 2017 08:11:04 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, alexei.starovoitov@...il.com,
        daniel@...earbox.net
Subject: Re: [PATCH net 04/10] bpf: offload: move offload device validation
 out to the drivers

Mon, Nov 20, 2017 at 05:55:16AM CET, jakub.kicinski@...ronome.com wrote:
>With TC shared block changes we can't depend on correct netdev
>pointer being available in cls_bpf.  Move the device validation
>to the driver.  Core will only make sure that offloaded programs
>are always attached in the driver (or in HW by the driver).  We
>trust that drivers which implement offload callbacks will perform
>necessary checks.
>
>Moving the checks to the driver is generally a useful thing,
>in practice the check should be against a switchdev instance,
>not a netdev, given that most ASICs will probably allow using
>the same program on many ports.
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>
>Acked-by: Alexei Starovoitov <ast@...nel.org>
>Acked-by: Daniel Borkmann <daniel@...earbox.net>

Acked-by: Jiri Pirko <jiri@...lanox.com>