netdev - Re: [RESEND PATCH] net: realtek: r8169: implement set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3167db00-cfe0-91da-e1cd-ac920339e864@applied-asynchrony.com>
Date:   Tue, 21 Nov 2017 19:06:27 +0100
From:   Holger Hoffstätte <holger@...lied-asynchrony.com>
To:     Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>, nic_swsd@...ltek.com
Cc:     netdev@...r.kernel.org, tremyfr@...il.com, davem@...emloft.net
Subject: Re: [RESEND PATCH] net: realtek: r8169: implement
 set_link_ksettings()

On 11/21/17 16:15, Tobias Jakobi wrote:
> Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially
> implemented the new ethtool API, by replacing get_settings()
> with get_link_ksettings(). This breaks ethtool, since the
> userspace tool (according to the new API specs) never tries
> the legacy set() call, when the new get() call succeeds.
> 
> All attempts to chance some setting from userspace result in:
>> Cannot set new settings: Operation not supported
> 
> Implement the missing set() call.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>

I've had this in my 4.9/4.14 trees for a while and not noticed any
problems, therefore:

Tested-by: Holger Hoffstätte <holger@...lied-asynchrony.com>

Thanks,

-h