netdev - Re: [RESEND PATCH] net: realtek: r8169: implement set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171121182132.GC30040@lunn.ch>
Date:   Tue, 21 Nov 2017 19:21:32 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, tremyfr@...il.com,
        davem@...emloft.net
Subject: Re: [RESEND PATCH] net: realtek: r8169: implement
 set_link_ksettings()

On Tue, Nov 21, 2017 at 04:15:57PM +0100, Tobias Jakobi wrote:
> Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially
> implemented the new ethtool API, by replacing get_settings()
> with get_link_ksettings(). This breaks ethtool, since the
> userspace tool (according to the new API specs) never tries
> the legacy set() call, when the new get() call succeeds.
> 
> All attempts to chance some setting from userspace result in:
> > Cannot set new settings: Operation not supported
> 
> Implement the missing set() call.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>

Fixes: 6fa1ba615205 ("net: realtek: r8169: use new api ethtool_{get|set}_link_ksettings")

It would be good to have this in stable.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew