netdev - Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171130.131448.1297231150498183814.davem@davemloft.net>
Date:   Thu, 30 Nov 2017 13:14:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ard.biesheuvel@...aro.org
Cc:     dan.j.williams@...el.com, will.deacon@....com,
        jassisinghbrar@...il.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, arnd.bergmann@...aro.org,
        robh+dt@...nel.org, mark.rutland@....com,
        jaswinder.singh@...aro.org
Subject: Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Date: Thu, 30 Nov 2017 18:08:34 +0000

> But the whole point of memremap() is obtaining a virtual mapping
> that does not require accessors, but can be used like ordinary
> memory.

That's unfortunately not what it's doing.

It's relying on the fact that some architectures (I guess x86
and arm) do happen to give a virutal address from ioremap_wt()
even though it's return type is annotated __iomem.

Thanks in advance for changing your driver to use ioremap() and
accessors for now.