netdev - Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201070919.mbyzbgud7ud42uqi@gauss3.secunet.de>
Date:   Fri, 1 Dec 2017 08:09:19 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <avivh@...lanox.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        Boris Pismenny <borisp@...lanox.com>,
        Yossi Kuperman <yossiku@...lanox.com>,
        "Yevgeny Kliteynik" <kliteyn@...lanox.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

On Tue, Nov 28, 2017 at 07:55:41PM +0200, avivh@...lanox.com wrote:
> From: Aviv Heller <avivh@...lanox.com>
> 
> Adding the state to the offload device prior to replay init in
> xfrm_state_construct() will result in NULL dereference if a matching
> ESP packet is received in between.
> 
> In order to inhibit driver offload logic from processing the state's
> packets prior to the xfrm_state object being completely initialized and
> added to the SADBs, a new activate() operation was added to inform the
> driver the aforementioned conditions have been met.

We discussed this already some time ago, and I still think that
we should fix this by setting XFRM_STATE_VALID only after the
state is fully initialized.