netdev - Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171203.103801.90553633657825548.davem@davemloft.net>
Date:   Sun, 03 Dec 2017 10:38:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     shli@...nel.org
Cc:     netdev@...r.kernel.org, kafai@...com, eric.dumazet@...il.com,
        flo@...rcot.fr, xiyou.wangcong@...il.com, tom@...bertland.com,
        shli@...com
Subject: Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for
 sk_txhash

From: Shaohua Li <shli@...nel.org>
Date: Fri,  1 Dec 2017 13:00:43 -0800

> This causes our router doesn't correctly close tcp connection.

Then please fix your router.

How many times do I have to say this...  The flowlabel is not part of
the socket connection identity, therefore you cannot use it for
connection state.

The more of these kinds of patches with this kind of nonsense in the
commit message I let into the tree the more this illusion of the
flowlabel meaning something on the connection level is made to seem
like reality.

Can we please stop pretending that the flowlabel is part of the
saddr/sport/daddr/dport socket identity?  Please???

I don't mind the flowlabel being set correctly, but your justification
stinks.