netdev - Re: [PATCH v2 net-next] netlink: optimize err assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171203.112200.2205442818284347522.davem@davemloft.net>
Date:   Sun, 03 Dec 2017 11:22:00 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     cugyly@....com, netdev@...r.kernel.org,
        Linyu.Yuan@...atel-sbell.com.cn
Subject: Re: [PATCH v2 net-next] netlink: optimize err assignment

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 03 Dec 2017 07:20:09 -0800

> On Sun, 2017-12-03 at 21:10 +0800, yuan linyu wrote:
>> From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
>> 
>> Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
>> ---
>> v2: fix kbuild test warning
>> ---
>>  net/netlink/af_netlink.c | 52 ++++++++++++++++++++----------------
>> ------------
>>  1 file changed, 22 insertions(+), 30 deletions(-)
>> 
> 
> I see no reason why we should accept this code churn.
> 
> This kind of change makes future fix backports harder.

I agree, and I've been trying to discourage these "improvements"
as much as possible.