netdev - Re: [PATCH net-next resubmit 2/2] net: phy: core: don't disable device interrupts in phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171204.102439.2288357008626128786.davem@davemloft.net>
Date:   Mon, 04 Dec 2017 10:24:39 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, netdev@...r.kernel.org,
        ard.biesheuvel@...aro.org
Subject: Re: [PATCH net-next resubmit 2/2] net: phy: core: don't disable
 device interrupts in phy_change

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 30 Nov 2017 23:57:00 +0100

> If state is not PHY_HALTED I see no need to temporarily disable
> interrupts on the device. As long as the current interrupt isn't acked
> on the device no new interrupt can happen anyway.
> 
> In addition remove a unneeded enabling of interrupts in the state
> machine when handling state PHY_CHANGELINK.
> 
> Tested on a Odroid-C2 with RTL8211F phy in interrupt mode.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Also applied, and again if this regresses things I'm reverting.