netdev - Re: [PATCH net-next resubmit 1/2] net: phy: core: remove now uneeded disabling of interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171204.102417.1919875184945871383.davem@davemloft.net>
Date:   Mon, 04 Dec 2017 10:24:17 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, netdev@...r.kernel.org,
        ard.biesheuvel@...aro.org
Subject: Re: [PATCH net-next resubmit 1/2] net: phy: core: remove now
 uneeded disabling of interrupts

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 30 Nov 2017 23:55:15 +0100

> After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from
> sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow
> some simplification" all relevant code pieces run in process context
> anyway and I don't think we need the disabling of interrupts any longer.
> 
> Interestingly enough, latter commit already removed the comment
> explaining why interrupts need to be temporarily disabled.
> 
> On my system phy interrupt mode works fine with this patch.
> However I may miss something, especially in the context of shared phy
> interrupts, therefore I'd appreciate if more people could test this.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Ok, applied.

But if this causes regressions I'm reverting.