netdev - Re: [PATCH v3 3/6] perf: implement pmu perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171204151547.fpqxxvf4jeiysia7@hirez.programming.kicks-ass.net>
Date:   Mon, 4 Dec 2017 16:15:47 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Song Liu <songliubraving@...com>
Cc:     rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        daniel@...earbox.net, kernel-team@...com
Subject: Re: [PATCH v3 3/6] perf: implement pmu perf_kprobe

On Thu, Nov 30, 2017 at 03:50:20PM -0800, Song Liu wrote:
> +	tp_event = create_local_trace_kprobe(
> +		func, (void *)(unsigned long)(p_event->attr.kprobe_addr),
> +		p_event->attr.probe_offset, p_event->attr.config != 0);

So you want to explicitly test bit0 instead? That would leave the other
63 bits available for future extension. The current implementation
completely consumes all 64bits of that config space.